filesystem: Fix error on max file size

Move the chmod call into the try block so we always call this when
add_file succeeds, otherwise new_file might not be set yet and we will
get an UnboundLocalError.

1 files changed, 2 insertions, 3 deletions

diff --git a/fbin/file_storage/filesystem.py b/fbin/file_storage/filesystem.py
index 07d29db..3a640bb 100644
--- a/fbin/file_storage/filesystem.py
+++ b/fbin/file_storage/filesystem.py
@@ -24,13 +24,12 @@ class Storage(BaseStorage):
             new_file = self.add_file(file_hash, uploaded_file.filename, size, user, ip)
             if new_file:
                 os.rename(temp_path, new_file.get_path())
+                if self.app.config.get('DESTINATION_MODE'):
+                    os.chmod(new_file.get_path(), self.app.config.get('DESTINATION_MODE'))
             return new_file
         except:
             os.unlink(temp.name)
             raise
-        finally:
-            if self.app.config.get('DESTINATION_MODE'):
-                os.chmod(new_file.get_path(), self.app.config.get('DESTINATION_MODE'))
 
     def get_file(self, f):
         path = f.get_path()